New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test_deepcopy_nested_attrs() (#2835). #7086

Merged

headtr1ck merged 3 commits into pydata:main from phockett:attrsDeepCopyTests

Sep 28, 2022

Contributor

phockett commented Sep 26, 2022

Tests for Dataset.copy(deep=True) does not deepcopy .attrs #2835 in case of nested DataArray attrs.
Tests added
Documented in whats-new.rst ('internals' section).


          Added test_deepcopy_nested_attrs() (pydata#2835).

f34eea1

phockett mentioned this pull request

Dataset.copy(deep=True) does not deepcopy .attrs #2835

Closed

headtr1ck mentioned this pull request

Fix deepcopy of Variables and DataArrays #7089

Merged

3 tasks

headtr1ck added 2 commits

September 28, 2022 22:21


          Merge branch 'main' into attrsDeepCopyTests

da980d9


          update test and mark xfail

8a07b2e

headtr1ck enabled auto-merge (squash)

September 28, 2022 20:28

Collaborator

headtr1ck commented Sep 28, 2022

@phockett thanks for the nice first PR 🥇

headtr1ck merged commit 6b2fdab into pydata:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet